Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boost: Add e2e tests for Image Guide #36716

Merged
merged 4 commits into from
Apr 3, 2024
Merged

Boost: Add e2e tests for Image Guide #36716

merged 4 commits into from
Apr 3, 2024

Conversation

dilirity
Copy link
Member

@dilirity dilirity commented Apr 3, 2024 •
edited
Loading

Part of #33877

Proposed changes:

  • Add helper plugin to append an image to single posts used for testing (same as in Boost: Add tests for Image CDN #36694 but renamed. PRs will be updated before merge to use one plugin instead of two);
  • Add e2e tests for the Image Guide module:
    • Image Guide functionality is not active when the module is inactive:
      • If script is not present on page;
    • Image Guide functionality is active when the module is active:
      • If script is present on page;
      • If admin bar item is present;
      • If image guide UI is present;
  • Update Boost CLI to support activating/deactivating Image Guide;
  • Update docker e2e test matrix to include tests (you can check the GH actions section to see the tests).

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

no

Testing instructions:

  • Run tests to see if everything is working as expected.

@dilirity dilirity added Docker [Status] Needs Team Review Actions GitHub actions used to automate some of the work around releases and repository management E2E Tests [Plugin] Boost A feature to speed up the site and improve performance. [Tests] Includes Tests labels Apr 3, 2024
@dilirity dilirity requested a review from a team April 3, 2024 09:30
@dilirity dilirity self-assigned this Apr 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

Boost plugin:

  • Next scheduled release: May 7, 2024.
  • Scheduled code freeze: April 29, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@dilirity dilirity mentioned this pull request Apr 3, 2024
Closed
haqadn
haqadn approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@haqadn haqadn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good. However, please rerun the tests before merging as some tests are failing(I think they aren't related to this change).

@dilirity
Copy link
Member Author

dilirity commented Apr 3, 2024

Tests were just acting up. I re-ran them a couple of times and they all passed 😅

@dilirity dilirity merged commit 72e68b8 into trunk Apr 3, 2024
60 of 62 checks passed
@dilirity dilirity deleted the add/boost/e2e-image-guide branch April 3, 2024 13:09
@dilirity dilirity mentioned this pull request Apr 3, 2024
Merged
3 tasks
TimBroddin pushed a commit that referenced this pull request Apr 10, 2024
@dilirity @TimBroddin
Boost: Add e2e tests for Image Guide (#36716)
ac74bf1 
* Update Boost's CLI to include support for image guide module

* Add e2e tests for image guide

* Add Boost's image guide test configuration to e2e test matrix

* add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haqadn haqadn haqadn approved these changes

Assignees

@dilirity dilirity

Labels
Actions GitHub actions used to automate some of the work around releases and repository management Docker E2E Tests [Plugin] Boost A feature to speed up the site and improve performance. [Tests] Includes Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dilirity @haqadn